Skip to content

[Shared Unlock] [PM-34073] Add WASM support#894

Draft
quexten wants to merge 2 commits intoinnovation-sprint/shared-unlock-core-protocolfrom
innovation-sprint/shared-unlock-wasm
Draft

[Shared Unlock] [PM-34073] Add WASM support#894
quexten wants to merge 2 commits intoinnovation-sprint/shared-unlock-core-protocolfrom
innovation-sprint/shared-unlock-wasm

Conversation

@quexten
Copy link
Copy Markdown
Contributor

@quexten quexten commented Apr 1, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34073

📔 Objective

Adds the wasm implementation for shared unlock.

🚨 Breaking Changes

@quexten quexten force-pushed the innovation-sprint/shared-unlock-wasm branch from cf2e246 to 3e539f2 Compare April 1, 2026 00:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Logo
Checkmarx One – Scan Summary & Detailsd62e1b26-3a3e-4109-8c34-f8ac2eb5007c


New Issues (1) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 LOW Parameter_Tampering /crates/bitwarden-uniffi/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 410
detailsMethod decryptVault at line 410 of /crates/bitwarden-uniffi/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt gets user input ...
Attack Vector

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

🔍 SDK Breaking Change Detection Results

SDK Version: innovation-sprint/shared-unlock-wasm (d26c27e)
Completed: 2026-04-01 07:47:47 UTC
Total Time: 279s

Client Status Details
typescript ❌ Breaking changes detected TypeScript compilation failed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 0% with 110 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (innovation-sprint/shared-unlock-core-protocol@bfdce29). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/bitwarden-shared-unlock/src/wasm/drivers.rs 0.00% 66 Missing ⚠️
...rates/bitwarden-shared-unlock/src/wasm/follower.rs 0.00% 22 Missing ⚠️
crates/bitwarden-shared-unlock/src/wasm/leader.rs 0.00% 22 Missing ⚠️
Additional details and impacted files
@@                               Coverage Diff                                @@
##             innovation-sprint/shared-unlock-core-protocol     #894   +/-   ##
================================================================================
  Coverage                                                 ?   82.67%           
================================================================================
  Files                                                    ?      366           
  Lines                                                    ?    43416           
  Branches                                                 ?        0           
================================================================================
  Hits                                                     ?    35893           
  Misses                                                   ?     7523           
  Partials                                                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coroiu coroiu changed the title Innovation sprint/shared unlock wasm [Shared Unlock] [PM-34073] Add WASM support Apr 1, 2026
@coroiu coroiu force-pushed the innovation-sprint/shared-unlock-core-protocol branch from 969f43f to bfdce29 Compare April 1, 2026 07:34
@coroiu coroiu force-pushed the innovation-sprint/shared-unlock-wasm branch from 32457fe to d26c27e Compare April 1, 2026 07:35
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant