rsky-video: remux MOV to MP4 before PDS upload#185
Open
rudyfraser wants to merge 1 commit intomainfrom
Open
Conversation
…ecordings) The bsky lexicon's app.bsky.embed.video#main rejects mimeType other than video/mp4. iPhone screen recordings ship as H.264/AAC inside a `qt ` QuickTime container; the PDS sniffs the bytes via file-type and tags the blob video/quicktime, so the subsequent applyWrites fails record validation. Detect the QuickTime brand (ftyp + qt ) on upload and remux to MP4 with ffmpeg `-c copy -movflags +faststart` -- stream copy, no re-encode. iPhone recordings pass straight through; the cost is the time to copy bytes once (typically <1s for 100MB). Falls through cleanly with TranscodeFailed for oddball MOVs (e.g. ProRes) that MP4 can't carry. This also wires the previously-orphan transcode module into the build: - mod transcode in main.rs - TranscodeFailed in Error enum - ffmpeg_path on AppConfig (FFMPEG_PATH env, default "ffmpeg") - tempfile promoted to runtime dep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes iPhone screen-recording uploads (
video/quicktime) being rejected by the bsky lexicon (video/mp4only). Detectsqtbrand and remuxes viaffmpeg -c copy(stream copy, no re-encode) before the PDS upload.Deployed and verified on
video.blacksky.community.