MB-71397: Add a maximal-effort strategy to avoid OOM errors for GPU indexes.#61
Draft
CascadingRadium wants to merge 6 commits into
Draft
MB-71397: Add a maximal-effort strategy to avoid OOM errors for GPU indexes.#61CascadingRadium wants to merge 6 commits into
CascadingRadium wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces per-device serialization for GPU cloning and adds a clone-time GPU free-memory admission check to reduce GPU oversubscription and mitigate TOCTOU issues when multiple goroutines clone indexes concurrently.
Changes:
- Add a per-GPU
gpuScheduler(per-device mutex) and use it to serializeCloneToGPUoperations on the same device. - Centralize GPU free-memory querying via
getFreeGPUMemory()and reuse it in the load balancer and clone path. - Update GPU selection/init logic to only start the load balancer when multiple GPUs are available, while always enabling the scheduler when any GPU exists.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
capemox
requested changes
May 11, 2026
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpuSerializer(per-device mutex), preventing concurrentCloneToGPUcalls from oversubscribing the same GPU.getFreeGPUMemoryreading taken under the scheduler lock, fixing the Time-of-Check to Time-of-Use (TOCTOU) race condition where stale load-balancer readings let concurrent callers all pass the threshold.defaultGPUMinFreeMemorymemory available for the sake of temporary allocations during the index lifetime.SizeAPI ofVectorIndexzapx#408