Update MeetupApiRequest.class.php #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you mention query in your notes, but it was missing from the source.
Owner
|
Sorry, where is query() mentioned? I could not find it on the wiki. Your code is an easy shortcut, and I see no reason why not to have something like that, however I am on the fence as to whether it should be implemented as this. I will put some thought into it. Anyone else have pros/cons? |
|
query() method is mentioned in the README line 66 as of blobaugh:master:6307311aaf |
Owner
|
Ah, I see now. I looked in the readme, my bad. There is also this wiki page https://github.com/blobaugh/Meetup-API-client-for-PHP/wiki/Making-direct-Api-calls Your solution is a decent shortcut, however you should return the entire response object, rather than the results. Let the devs chose how to handle it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you mention query in your notes, but it was missing from the source.