This repository was archived by the owner on Jan 22, 2026. It is now read-only.
feat(rates): removed usage of socket for getting rates#6384
Open
milan-bc wants to merge 1 commit intodevelopmentfrom
Open
feat(rates): removed usage of socket for getting rates#6384milan-bc wants to merge 1 commit intodevelopmentfrom
milan-bc wants to merge 1 commit intodevelopmentfrom
Conversation
milan-bc
requested review from
CTucker-BC,
TheLeoB,
dkremniov-bc,
jjBlockchain,
mperdomo-bc and
mrodriguez-bc
as code owners
gcafarelli-bc
approved these changes
Jun 7, 2024
|
👏 |
|
No New Or Fixed Issues Found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (optional)
This WS returning no rates and we are going to deprecate it based on this this PR is preparation for this
Testing Steps (optional)
Detail the steps required for the reviewer(s) to verify and test these changes.