Skip to content

feat: Add recipient to changes requested email #5728

Merged
millord merged 6 commits intomainfrom
5608/add-recipient-to-changes-requested-email
Jan 9, 2026
Merged

feat: Add recipient to changes requested email #5728
millord merged 6 commits intomainfrom
5608/add-recipient-to-changes-requested-email

Conversation

@millord
Copy link
Collaborator

@millord millord commented Dec 29, 2025

This PR addresses #5608

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

The purpose of this ticket is that we want UserRoleEnum.limitedJurisdictionAdmin with access to the listing should receive the email when the admin requests changes. So I modified the listingApprovalNotify in the listing.service.ts for this.

How Can This Be Tested/Reviewed?

Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@netlify
Copy link

netlify bot commented Dec 29, 2025

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit afb197e
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/69612fee2814230008832774
😎 Deploy Preview https://deploy-preview-5728--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 29, 2025

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit afb197e
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/69612feeda1f5c0008a2d6e5

@netlify
Copy link

netlify bot commented Dec 29, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit afb197e
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/69612fee511ffe0008d2d878
😎 Deploy Preview https://deploy-preview-5728--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@millord millord changed the title added the limited juris admin to list to get email feat: dd recipient to changes requested email Dec 29, 2025
@millord millord changed the title feat: dd recipient to changes requested email feat: Add recipient to changes requested email Dec 29, 2025
@millord millord marked this pull request as ready for review December 29, 2025 19:26
@millord millord added the 1 review needed Requires 1 more review before ready to merge label Dec 29, 2025
@ludtkemorgan ludtkemorgan added the needs changes The author must make changes and then re-request review before merging label Jan 8, 2026
@millord millord removed the 1 review needed Requires 1 more review before ready to merge label Jan 8, 2026
@netlify
Copy link

netlify bot commented Jan 8, 2026

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit afb197e
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/69612fee5263b7000826f8ed
😎 Deploy Preview https://deploy-preview-5728--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 8, 2026

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit afb197e
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/69612fee8fd4d1000872e229
😎 Deploy Preview https://deploy-preview-5728--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 8, 2026

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit afb197e
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/69612fee1dbeb50008060f81
😎 Deploy Preview https://deploy-preview-5728--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@millord millord added 1 review needed Requires 1 more review before ready to merge and removed needs changes The author must make changes and then re-request review before merging labels Jan 8, 2026
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good. You just need to make a small change to the test for it to pass but otherwise looks good. So you can merge it after you make that change

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jan 9, 2026
@millord millord merged commit be39e9f into main Jan 9, 2026
35 of 36 checks passed
@millord millord deleted the 5608/add-recipient-to-changes-requested-email branch January 9, 2026 17:11
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Feb 2, 2026
giving UserRoleEnum.limitedJurisdictionAdmin permissions to receive email when the admin requests changes
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Feb 3, 2026
giving UserRoleEnum.limitedJurisdictionAdmin permissions to receive email when the admin requests changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants