fix(bal): ensure sorted writes in Alloy type conversions #3286
+12
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From/TryFromimplementations for Alloy EIP-7928 types now useSelf::new()to ensure writes are sorted by
block_access_index.Problem
BalWrites::get()relies on sorted data for correct binary/linear search.However, Alloy types (
Vec<BalanceChange>, etc.) do not guarantee ordering.Using direct struct initialization (
Self { writes: ... }) bypassed sorting,potentially causing incorrect lookups.
Solution
Replace
Self { writes: ... }withSelf::new(...)which sorts the data.Changes
alloy.rs: 4 conversions updated (BalanceChange,NonceChange,StorageChange,CodeChange)