Skip to content

webrtc: strip TWCC extension of incoming RTP packets (#5146)#5605

Merged
aler9 merged 1 commit intomainfrom
fix/twcc-extension
Mar 23, 2026
Merged

webrtc: strip TWCC extension of incoming RTP packets (#5146)#5605
aler9 merged 1 commit intomainfrom
fix/twcc-extension

Conversation

@aler9
Copy link
Member

@aler9 aler9 commented Mar 22, 2026

Fixes #5146

The TWCC extension is used as part of the WebRTC congestion control algorithm placed between the publisher and the server. If this extension is routed untouched from the server to readers, it messes with the congestion control algorithm present between the server and each reader. Remove it.

@codecov
Copy link

codecov bot commented Mar 22, 2026

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.06%. Comparing base (33f1281) to head (471b132).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/protocols/webrtc/incoming_track.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5605      +/-   ##
==========================================
+ Coverage   62.02%   62.06%   +0.04%     
==========================================
  Files         205      205              
  Lines       17363    17379      +16     
==========================================
+ Hits        10769    10786      +17     
+ Misses       5709     5707       -2     
- Partials      885      886       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The TWCC extension is used as part of the WebRTC congestion control
algorithm placed between the publisher and the server. If this
extension is routed untouched from the server to readers, it messes
with the congestion control algorithm present between the server and
each reader. Remove it.
@aler9 aler9 force-pushed the fix/twcc-extension branch from b88cdf6 to 471b132 Compare March 23, 2026 12:56
@aler9 aler9 merged commit d5d1de0 into main Mar 23, 2026
12 checks passed
@aler9 aler9 deleted the fix/twcc-extension branch March 23, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] WebRTC Audio Forwarding: transport-cc Extension ID Mismatch

1 participant