-
Notifications
You must be signed in to change notification settings - Fork 115
backend: Update zenoh to latest version #3383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
backend: Update zenoh to latest version #3383
Conversation
Reviewer's GuideThe PR bumps the zenoh SDK version from 1.3.4 to 1.4.0 by updating the frontend dependency and the bootstrap script to align with the latest release. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @patrickelectric - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
a423218 to
b0be7dc
Compare
|
I think that now we have 1.5.0 that should work. |
b0be7dc to
4bc8eef
Compare
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
4bc8eef to
0ceb6ca
Compare
|
|
I didn't follow |
Oh, it's just because it's using 1.3.4 for the frontend side, so the PR name isn't strictly accurate. (you have just explained in the meeting though) |
It's also in the PR body. |
|
The data is being sent to Foxglove, but our frontend Zenoh inspector page is not showing anything. |
Update everything besides frontend to 1.5.0
The frontend requires a major change since the api changed a lot, will work around it in the next PR