Skip to content

Conversation

@patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Oct 30, 2025

Add page in system information page (mcap log soon)
Helps to replace #3456
Better merged after #3624

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 30, 2025

Reviewer's Guide

This PR implements a new “journal” feature end-to-end by extending the system-information store to handle journal entries (with Vuex mutations, API fetch and WebSocket), adding a dedicated Journal Vue component with virtual scroll and formatting, updating the main view to expose the journal tab, and bumping the linux2rest bootstrap version.

Sequence diagram for fetching and displaying journal entries

sequenceDiagram
    actor User
    participant SystemInformationView
    participant SystemInformationStore
    participant Backend
    participant JournalComponent
    User->>SystemInformationView: Selects "Journal" tab
    SystemInformationView->>JournalComponent: Mounts component
    JournalComponent->>SystemInformationStore: fetchSystemInformation(JournalType)
    SystemInformationStore->>Backend: Request journal entries
    Backend-->>SystemInformationStore: Returns JournalResponse
    SystemInformationStore->>JournalComponent: Updates journal_entries
    JournalComponent->>User: Displays journal entries
Loading

Class diagram for new and updated types in journal feature

classDiagram
    class SystemInformationStore {
        +journal_entries: JournalEntry[]
        +appendJournalEntries(response: JournalResponse): void
        +updateJournalEntries(response: JournalResponse): void
    }
    class JournalEntry {
        +cursor?: string
        +timestamp?: string
        +priority?: number
        +identifier?: string
        +unit?: string
        +pid?: number
        +hostname?: string
        +message: string
    }
    SystemInformationStore "1" -- "*" JournalEntry: contains
Loading

File-Level Changes

Change Details Files
Extend Vuex store to support JournalType
  • Added JournalType enum and journal_entries state
  • Introduced appendJournalEntries and updateJournalEntries mutations
  • Handled FetchType.JournalType in the data switch
  • Created WebSocket listener and initial fetch for journal entries
core/frontend/src/store/system-information.ts
Integrate journal tab in main SystemInformationView
  • Imported Journal component
  • Added journal tab entry and conditional rendering
core/frontend/src/views/SystemInformationView.vue
Add Journal component and types
  • Implemented Journal.vue with virtual scroll, timestamp formatting, priority labels and styles
  • Created JournalEntry interface with relevant fields
core/frontend/src/components/system-information/Journal.vue
core/frontend/src/types/system-information/journal.ts
Bump linux2rest bootstrap version
  • Updated VERSION from v0.6.3 to v0.8.0
core/tools/linux2rest/bootstrap.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Williangalvani
Copy link
Member

I think I found a frontend bug:
Screenshot 2025-10-31 at 15 15 55
This happened when new messaged popped up while I had the journal tab open

@patrickelectric
Copy link
Member Author

I think I found a frontend bug: Screenshot 2025-10-31 at 15 15 55 This happened when new messaged popped up while I had the journal tab open

Check now, it should be working

@patrickelectric patrickelectric merged commit 9bd5eea into bluerobotics:master Nov 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants