Skip to content

Conversation

@Granjow
Copy link

@Granjow Granjow commented Dec 11, 2022

The LD pressure sensors have a configurable I²C address. This MR allows to use the sensors even if they use a different address, and thus would also allow to interface with multiple sensors on the same I²C bus.

Additionally, it adds a PlatformIO file which is helpful for development as the project can easily be opened with CLion, VS Code, etc.

@Granjow Granjow force-pushed the feature/granjow/choose-i2c-address branch 2 times, most recently from 8692f81 to e78199a Compare December 11, 2022 22:00
@Granjow
Copy link
Author

Granjow commented Feb 19, 2024

@patrickelectric Any chance this MR is going to be merged? If yes, I will fix the conflict.

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Granjow, sorry for taking this long to review, it got somehow lost in my list.
Be free to ping me in any PR or issue if I do not reply in the desirable time.

[env:promini]
platform = atmelavr
board = pro8MHzatmega328
framework = arduino
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is also not necessary.

.gitignore Outdated
.idea
CMake*
CMakeListsPrivate.txt
cmake-build-*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unnecessary, we don't use cmake in this project. Also the others formats feel unimportant. Usually .gitignore files are used to put generated files by the project or build tools. And I don't see the case here for this project.

@Granjow Granjow force-pushed the feature/granjow/choose-i2c-address branch from f5310e0 to 75929c3 Compare February 20, 2024 12:18
@Granjow
Copy link
Author

Granjow commented Feb 20, 2024

Thanks @patrickelectric for the review!

I added some files (platformio.ini and main.cpp) because it greatly simplifies development. I can open the platformio.ini file in CLion and I have full IDE support; and because of the main.cpp I can build the project and see if there are build errors. I assume it is the same for VSCode. It would also allow to use a CI pipeline for automated testing (at least checking for build failures). I'm not familiar with GitHub, but it should be a matter of minutes to set up CI with PlatformIO.

This is why I'd keep the files in the repo, but if you want to have them deleted, I can do that.

CMake was an artifact from an earlier version of the PlatformIO plugin for CLion. I removed it.

@patrickelectric
Copy link
Member

Hi @Granjow, sorry for losing track of this PR, can you rebase over master ?

@Granjow Granjow force-pushed the feature/granjow/choose-i2c-address branch from 73a52bc to 6f9639a Compare February 3, 2025 20:58
@Granjow
Copy link
Author

Granjow commented Feb 3, 2025

Hi @patrickelectric , done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants