chore(oauth-provider): upgrade cookie to 2.x, drop @types/cookie - #5406
Open
dreyfus92 wants to merge 1 commit into
Open
chore(oauth-provider): upgrade cookie to 2.x, drop @types/cookie#5406dreyfus92 wants to merge 1 commit into
dreyfus92 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
this bumps
cookiefrom 0.7.0 to 2.0.1 in theoauth-providerpackage and drops@types/cookiesince cookie ships its own types now.the 2.x api renames a couple things so i migrated to
parseCookie/stringifySetCookie, and added aMath.floor()on maxAge because 2.x throws on non-integers.the fun part was that a global pnpm override was silently pinning cookie to 0.7.2, so i scoped it to
express>cookieinstead, express keeps its patched version and oauth-provider gets 2.0.1. left a TODO noting the override can go away once express 5 lands. full build, unit tests and the pds oauth integration tests all pass.related: #5341
Checklist
pnpm build --force && pnpm verifypasses