Wrap long handles, simplify delete account dialog copy - #5420
Open
bigmoves wants to merge 1 commit into
Open
Conversation
bigmoves
force-pushed
the
bigmoves/handle-ellipsis-mobile
branch
from
August 17, 2026 17:47
952aec4 to
9fc50f6
Compare
bigmoves
changed the title
`Handle` forced `whitespace-nowrap`, so a custom-domain username had no break opportunity anywhere and ran past the right edge of every dialog that names it — the delete-account dialog, the consent screens, the About page. This is the username half of the fix bluesky-social#5377 made for email addresses. It now sets `break-words` instead: a username has no space to break at, so it still occupies one line whenever it fits, and only breaks when it would otherwise overflow. The contexts that want a single line — the settings rows, `AccountSummary`, `AccountCard`, the account menu — already pass `truncate`, which brings its own `whitespace-nowrap` and still ellipsizes. The delete-account dialog's title is also just "Delete account" now. A title is the worst place for a long variable string: a custom domain wrapped to three bold lines and pushed the copy below the fold on a phone. The account is still named on the final confirmation, where it reads as prose and is the last gate before an irreversible action. The plain msgid already existed as the no-handle fallback, so this drops one msgid and adds none. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
bigmoves
force-pushed
the
bigmoves/handle-ellipsis-mobile
branch
from
August 17, 2026 17:57
9fc50f6 to
f25c0f0
Compare
bigmoves
marked this pull request as ready for review
August 17, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Handleforcedwhitespace-nowrap, so a long custom-domain username ran past the right edge of every dialog that quotes it — delete account, consent, About. This is the username half of Show current account values on narrow viewports #5377, which fixed the same thing for email addresses.break-words, so a username still sits on one line whenever it fits and only breaks when it would otherwise overflow.AccountSummary,AccountCard, account menu) passtruncateand still ellipsize — unchanged.Delete account <0/>), adds none.Delete-account dialog at 320px
Checklist
pnpm build --force && pnpm verifypassesoauth-provider-ui). No new test — the change is CSS classes and one static string.