internal/xrpc-utils: drop redundant @atproto/xrpc dependency - #5424
Open
bigmoves wants to merge 1 commit into
Open
internal/xrpc-utils: drop redundant @atproto/xrpc dependency#5424bigmoves wants to merge 1 commit into
bigmoves wants to merge 1 commit into
Conversation
`ResponseType` was the only symbol `@atproto-labs/xrpc-utils` used from `@atproto/xrpc`, and `@atproto/xrpc-server` — which the package already depends on — re-exports it. Import it from there instead, and drop the dependency plus its tsconfig project reference. Same enum, no behavior change. Also switch the last two in-repo callers of the deprecated `isUnicastIp` alias (pds pipethrough, bsky blob-dispatcher) to `isUnicastIpHostname`. The alias itself stays in `@atproto-labs/fetch-node`, since that package is published and removing it would break external consumers. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
bigmoves
changed the title
bigmoves
marked this pull request as ready for review
August 18, 2026 00:46
devinivy
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
ResponseTypewas the only symbol@atproto-labs/xrpc-utilsused from@atproto/xrpc, and@atproto/xrpc-server— which the package already depends on — re-exports it. Importing it from there lets the extra dependency and its tsconfig project reference go away. Same enum, no behavior change.Also switches the last two in-repo callers of the deprecated
isUnicastIpalias (pdspipethrough,bskyblob-dispatcher) toisUnicastIpHostname. The alias itself stays in@atproto-labs/fetch-node— it's published, so removing it would break external consumers.Both changes are behavior-preserving, so there's nothing new to cover with tests.
Checklist
pnpm build && pnpm verifypasses