Document safe rendering of link facets#398
Open
ThisIsMissEm wants to merge 3 commits intobluesky-social:mainfrom
Open
Document safe rendering of link facets#398ThisIsMissEm wants to merge 3 commits intobluesky-social:mainfrom
ThisIsMissEm wants to merge 3 commits intobluesky-social:mainfrom
Conversation
Added section on safely rendering link facets and URI sanitization.
romellem
reviewed
Jan 8, 2026
Co-authored-by: Matt Wade <romellem@users.noreply.github.com>
This adds a more basic example of sanitization of link facets, which should work for most cases.
ThisIsMissEm
commented
Jan 9, 2026
Comment on lines
-327
to
+328
| </Tabs> No newline at end of file | ||
| </Tabs> |
Author
There was a problem hiding this comment.
I'm not sure what this change is about, I definitely didn't make a change here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added section on safely rendering link facets and URI sanitization.
Based on the recent XSS attempt against Bluesky: https://bsky.app/profile/scoiattolo.mountainherder.xyz/post/3mbuvztjijs2y