feat(dashboard): make prometheus and loki datasource less hardcoded #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstruck
force-pushed
the
make_dashboard_more_datasource_agnostic
branch
from
e85904b to
34d06ac
Compare
cstruck
force-pushed
the
make_dashboard_more_datasource_agnostic
branch
from
34d06ac to
4ffdd78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most dashboards already use variables to select the datasources. This is useful since not all deployed grafana instances always name their datasource uid
prometheusorloki.This PR enables setting the dashboards datasources and if uid: loki and/or uid:prometheus are not available will by default take one of the type for the datasource that exists, while retaining the old behavior by defaulting to
lokiandprometheusif they exist.