Stop using more-itertools #437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
mm-rm-more-itertools
branch
from
e483f1b to
8815a61
Compare
blueyed
force-pushed
the
mm-rm-more-itertools
branch
from
0051f0a to
a9aec38
Compare
We barely use it; the couple places that do are not really worth the extra dependency, I think the code is clearer without it. Also simplifies one (regular) itertools usage. Also improves a check and an error message in `pytest.raises`. (cherry picked from commit 96a48f0) Conflicts: setup.cfg src/_pytest/python_api.py src/_pytest/terminal.py
…est_typechecking (regressed in 2dca68)
…cker::test_typechecking (regressed in 2dca68)
blueyed
force-pushed
the
mm-rm-more-itertools
branch
from
b9c3dee to
4e336c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We barely use it; the couple places that do are not really worth the
extra dependency, I think the code is clearer without it.
Also simplifies one (regular) itertools usage.
Also improves a check and an error message in
pytest.raises.(cherry picked from commit 96a48f0)
Conflicts:
setup.cfg
src/_pytest/python_api.py
src/_pytest/terminal.py