Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates the npm publishing GitHub Actions workflows to rely on npm trusted publishing (OIDC) rather than passing an npm token via NODE_AUTH_TOKEN, while also bumping core GitHub Actions versions.
Changes:
- Upgraded
actions/checkoutandactions/setup-nodetov6in the CLI publish workflow. - Removed
NODE_AUTH_TOKENfrom the npm publish steps in both SDK and CLI workflows (shifting auth expectations to OIDC/trusted publishing).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/cli-npm.yml | Upgrades actions versions and removes token-based npm auth for publishing (expects OIDC/trusted publishing). |
| .github/workflows/sdk-npm.yml | Removes token-based npm auth for publishing (expects OIDC/trusted publishing). |
Comments suppressed due to low confidence (2)
.github/workflows/sdk-npm.yml:50
- After removing
NODE_AUTH_TOKEN, this workflow no longer configures any npm registry authentication (no_authTokenin repo and no token env var here). Unless@gobob/bob-sdkis configured for npm/GitHub trusted publishing and the publish command is using the OIDC-based flow,npm publishwill fail with an auth error. Consider either adding--provenance(to align withcli-npm.ymland explicitly use the OIDC/provenance path) or restoringNODE_AUTH_TOKENfor this workflow.
- name: publish to npm
if: env.PUBLISH == 'true'
run: |
if [[ "${{ steps.version.outputs.version }}" == *rc* ]]; then
npm publish --access public --tag rc
else
npm publish --access public
.github/workflows/cli-npm.yml:76
- This publish step no longer provides
NODE_AUTH_TOKEN, so npm authentication now depends entirely on npm/GitHub trusted publishing (OIDC). If@gobob/gateway-cliis not configured for trusted publishing in npm, this workflow will start failing with 401s; consider adding a short comment/link to the expected npm setup or restoring token-based auth.
- name: Publish
if: env.PUBLISH == 'true'
run: |
if [[ "${{ steps.version.outputs.version }}" == *rc* ]]; then
npm publish --access public --provenance --tag rc
else
npm publish --access public --provenance
fi
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the GitHub Actions workflows for publishing to npm, focusing on upgrading the versions of key actions and modifying the way environment variables are handled during the publish steps.
Workflow Action Upgrades:
actions/checkoutandactions/setup-nodeactions from versionv4tov6in thecli-npm.ymlworkflow to use the latest features and security updates.Environment Variable Handling:
NODE_AUTH_TOKENenvironment variable in the publish steps of bothcli-npm.ymlandsdk-npm.yml, which may indicate a shift to relying on default authentication mechanisms or configuration elsewhere in the workflow. [1] [2]