chore: bump gateway-cli version 0.1.2#1031
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the @gobob/gateway-cli version to 0.1.2 and bumps the @gobob/bob-sdk dependency to 5.3.2. A critical issue was identified regarding the SDK update, which incorrectly introduces linting-related packages into the production dependency graph and references non-existent versions (e.g., globals@17.4.0), which will likely cause installation failures for external users.
| }, | ||
| "dependencies": { | ||
| "@gobob/bob-sdk": "^5.3.1", | ||
| "@gobob/bob-sdk": "^5.3.2", |
There was a problem hiding this comment.
The update to @gobob/bob-sdk@5.3.2 introduces several linting-related packages (@eslint/eslintrc, @eslint/js, and globals) into the production dependency graph. These are incorrectly listed as dependencies in the SDK's package.json instead of devDependencies. Furthermore, the version 17.4.0 for globals (and 10.0.1 for @eslint/js seen in the lockfile) appears to be non-standard or hallucinated, as these versions do not exist on the public npm registry. This will likely cause installation failures for external users and unnecessarily bloats the production environment. Please verify the SDK configuration before proceeding with this bump.
2 participants
No description provided.