Added getVolume() #2
Conversation
Added the option to get the current volume
| @@ -1,4 +1,4 @@ | |||
| # cordova-volume-control | |||
| # cordova-simple-volume | |||
There was a problem hiding this comment.
Is see you changed the name of the plugin. I'm assuming this is because another plugin has claimed the npm namespace. I'm open to changing this, but it would be good if releases of this package would be in sync with this repo.
There was a problem hiding this comment.
I didn't change the name I just folked a folk which had already changed the name? I have no preference on name
| ## Installation | ||
|
|
||
| cordova plugin add https://github.com/boedy/cordova-volume-control --save | ||
| cordova plugin add https://github.com/online-data-intelligence/cordova-simple-volume |
There was a problem hiding this comment.
This was just for my testing on my folk. I will put everything to point to the main repo
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/online-data-intelligence/cordova-simple-volume.git" |
There was a problem hiding this comment.
This was just for my testing on my folk. I will put everything to point to the main repo
| "author": "Boudewijn Geiger", | ||
| "license": "Apache 2.0", | ||
| "bugs": { | ||
| "url": "https://github.com/online-data-intelligence/cordova-simple-volume/issues" |
| setVolume: function (volume) { | ||
| cordova.exec(null, null, "VolumeControl", "setVolumeCommand", [volume]); | ||
| }, | ||
| getVolume: function () { |
There was a problem hiding this comment.
iOS does not support es6 syntax. So arrow functions (=>) don't work.
There was a problem hiding this comment.
Thats strange as the plugin works on my iPhone? I will remove and test without the arrow functions.
There was a problem hiding this comment.
Ah it seems it works on the newer iOS safari versions . It would be good to support older versions too though (e.g iPod touch 5th generation is on iOS 9).
3 participants
Added getVolume() which returns a promise with the current volume set.