Skip to content

fix: Remove LooseVersion - #115

Merged
philippjfr merged 3 commits into
mainfrom
fix_looseversion
Apr 3, 2025
Merged

fix: Remove LooseVersion#115
philippjfr merged 3 commits into
mainfrom
fix_looseversion

Conversation

@hoxbro

@hoxbro hoxbro commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Fixes #109

kernel_version is no longer used, so we can remove the import of LooseVersion.

@peytondmurray

Copy link
Copy Markdown
Contributor

Thanks for this, I was just running into this on #64. I'm not sure what the intent was in defining kernel_version; I guess for compatibility we could use packaging.version.Version in case someone is making use of it, although I'd be surprised if it was.

@hoxbro

hoxbro commented Apr 3, 2025

Copy link
Copy Markdown
Contributor Author

It was added in #36 to be compatible with ipykernel 6 and was removed in #93.

Replacing it with packaging.version.Version will still break if people use it, as it no longer works with string equality check. So, I don't think it is worth keeping.

@hoxbro hoxbro mentioned this pull request Apr 3, 2025
@hoxbro
hoxbro requested a review from philippjfr April 3, 2025 13:36
@philippjfr
philippjfr merged commit bbd6195 into main Apr 3, 2025

@developers001 developers001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All issues resolveed

@developers001 developers001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit

@mattpap
mattpap deleted the fix_looseversion branch February 17, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Python>=3.12

4 participants