Skip to content

ft/add support for monotonic/sequential IDs and move the generation options class#28

Merged
bolorundurowb merged 22 commits intomasterfrom
ft/#23/support-monotonic-ids
Mar 7, 2026
Merged

ft/add support for monotonic/sequential IDs and move the generation options class#28
bolorundurowb merged 22 commits intomasterfrom
ft/#23/support-monotonic-ids

Conversation

@bolorundurowb
Copy link
Copy Markdown
Owner

Thanks to @vanillajonathan and @skyxioo for the feedback

…es in `ShortId`, allow internals access for tests in csproj
…s for custom options and character pool handling
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 93.05556% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.42%. Comparing base (6a2aa37) to head (8c3362c).

Files with missing lines Patch % Lines
src/shortid/Utils/CommonUtilities.cs 83.33% 2 Missing and 1 partial ⚠️
src/shortid/ShortId.cs 95.34% 0 Missing and 2 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (6a2aa37) and HEAD (8c3362c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6a2aa37) HEAD (8c3362c)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##            master      #28      +/-   ##
===========================================
- Coverage   100.00%   93.42%   -6.58%     
===========================================
  Files            3        3              
  Lines           56       76      +20     
  Branches         8       12       +4     
===========================================
+ Hits            56       71      +15     
- Misses           0        2       +2     
- Partials         0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bolorundurowb bolorundurowb merged commit 652030c into master Mar 7, 2026
2 checks passed
@bolorundurowb bolorundurowb deleted the ft/#23/support-monotonic-ids branch March 7, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants