Removes async_append_some #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarthal
reviewed
Jul 10, 2025
| if (!on_push_) // Prepare for new message. | ||
| on_push_ = is_next_push(); | ||
| on_push_ = is_next_push(data); |
There was a problem hiding this comment.
This is likely not something to fix in this PR, but isn't the multiplexer violating point 1. in the comment above? While we're parsing something that's not a push and we run out of data, on_push_ will be false and we will look at the message's first byte even if we shouldn't.
There was a problem hiding this comment.
I have to review this again and test it. I remember it being trick see comments in is_next_push.
mzimbres
force-pushed
the
refactoring_clean_code
branch
3 times, most recently
from
df2036b to
918889d
Compare
mzimbres
force-pushed
the
refactoring_clean_code
branch
from
918889d to
8ee2213
Compare
|
@anarthal I think I addressed all your comments. Your other PR will fix the remaining problems. |
|
Looks good to me. I'll merge mine after you merge this. |
anarthal
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anarthal Before I start investigating how to proceed with @D0zee PR I would like to merge this one which simplifies how the read buffer is used.