Skip to content

Conversation

@jonathandiep
Copy link
Contributor

@jonathandiep jonathandiep commented Oct 2, 2025

Description

follow up of #486

Summary by CodeRabbit

  • Chores
    • Updated release pipeline configuration for main-branch builds to improve stability and performance of the release build step.
    • Aligned environment handling for the build command to ensure consistent behavior across environments.
    • Internal CI-only change; no impact on application features, UI, or APIs. No action required from users.

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2025

⚠️ No Changeset found

Latest commit: ea9e0ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@boostxyz/test" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@coderabbitai
Copy link

coderabbitai bot commented Oct 2, 2025

Walkthrough

Updates the GitHub Actions workflow to set NODE_OPTIONS="--max-old-space-size=8192" inline for the release build command invoking turbo, without altering other environment settings.

Changes

Cohort / File(s) Summary
CI workflow
.github/workflows/on-push-to-main.yml
Added inline NODE_OPTIONS="--max-old-space-size=8192" prefix to the turbo release build command, leaving the existing env block unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A bunny builds with hoppity cheer,
More memory now, the path is clear.
Turbo zooms, no OOM fright,
Carrots stacked, the logs look right.
Thump-thump—release takes flight! 🥕🚀

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description only cites a follow-up link and lacks the required template sections and a summary of what changed, why it was needed, and how it affects the build process, so it does not meet the repository’s description template requirements. Please expand the description to include the full template header and a detailed explanation of the change—summarize the inline NODE_OPTIONS assignment, its rationale (increasing max-old-space size), and any testing steps—per the repository’s pull request description template.
Title Check ❓ Inconclusive The title indicates a CI change but is too generic and does not specify which environment variable is being used or why the change is needed, making it unclear to someone reviewing history what the primary adjustment entails. Please update the title to clearly reference the specific environment variable (e.g. NODE_OPTIONS) and its purpose (increasing memory for the release build step) so that it succinctly conveys the main change.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jon/increase-build-size-3

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 07e657f and ea9e0ab.

📒 Files selected for processing (1)
  • .github/workflows/on-push-to-main.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Verify / Verify

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonathandiep
Copy link
Contributor Author

Warnings
⚠️

By using the [ADHOC] title prefix, you are bypassing best practice protections.

⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against ea9e0ab

1 similar comment
@jonathandiep
Copy link
Contributor Author

Warnings
⚠️

By using the [ADHOC] title prefix, you are bypassing best practice protections.

⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against ea9e0ab

@jonathandiep jonathandiep merged commit b36f86d into main Oct 2, 2025
7 checks passed
@jonathandiep jonathandiep deleted the jon/increase-build-size-3 branch October 2, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants