fix typos and grammar (master) #8999
Merged
+1,704
−1,703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasWaldmann
force-pushed
the
typos-grammar-master
branch
from
4bb03c8 to
525dd28
Compare
ThomasWaldmann
force-pushed
the
typos-grammar-master
branch
from
525dd28 to
722e974
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8999 +/- ##
==========================================
- Coverage 81.44% 81.43% -0.02%
==========================================
Files 77 77
Lines 13524 13515 -9
Branches 2005 2004 -1
==========================================
- Hits 11015 11006 -9
Misses 1853 1853
Partials 656 656 ☔ View full report in Codecov by Sentry. |
ThomasWaldmann
commented
Sep 4, 2025
The original markup included a paragraph element wrapping a block-level pre element, which is invalid per HTML’s content model (a p can only contain phrasing content; pre is flow content). The fix separated text and pre blocks into valid sibling elements, ensuring no pre is nested inside a p.
this was done by Junie AI.
ThomasWaldmann
force-pushed
the
typos-grammar-master
branch
from
722e974 to
2c7bec0
Compare
ThomasWaldmann
commented
Sep 23, 2025
Comment on lines
253
to
255
| for pattern in matcher.get_unmatched_include_patterns(): | ||
| self.print_warning_instance(IncludePatternNeverMatchedWarning(pattern)) | ||
|
|
There was a problem hiding this comment.
That was a bad Junie mistake: although it was only asked to fix grammar and typos, it removed this code!
The code maybe wasn't working (see the added import for the warning class), but still a rather unexpected AI action.
There was a problem hiding this comment.
I fixed it manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.