Housekeeping #23
Housekeeping #23
Conversation
nikku
requested review from
a team,
jarekdanielak and
barmac
and removed request for
a team
bpmn-io-tasks
bot
added
needs review
|
There is more stuff to be done, i.e. to turn this library into a true dual ESM/CommonJS module. But that would require to fix the upstream (broken, bundling wise) |
There was a problem hiding this comment.
bpmn-moddle 8 or 9? 🤔
There was a problem hiding this comment.
v9 does not fly yet, because the diffpatch library we use is a fake ESM module, we cannot move to ESM testing, but bpmn-moddle@9 does not work with emulation via esm anymore.
There was a problem hiding this comment.
I was asking because the commit message and the actual version weren't matching. 🙂
There was a problem hiding this comment.
Otherwise this PR looks good and could be merged.
There was a problem hiding this comment.
bpmn-io/diffpatch#2 should enable (once released and integrated) the update to bpmn-moddle@9.
There was a problem hiding this comment.
There you go: 8f465fd ✔️
Smaller bundle size, get rid of legacy.
Latest [email protected] ships without cruft (:tm:)
Proposed Changes
Modernizes the basic setup around this library:
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}