Skip to content

fix(scripts): strip ELECTRON_RUN_AS_NODE before spawning Electron #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brafdlog merged 1 commit into from
Apr 26, 2026
+8 −1
Merged

fix(scripts): strip ELECTRON_RUN_AS_NODE before spawning Electron #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/scrape.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,7 @@ if (mainNeedsRebuild || preloadNeedsRebuild) {
}

console.log('Starting scrape...');
execSync('electron . --scrape', { stdio: 'inherit', cwd: projectRoot });
// Strip ELECTRON_RUN_AS_NODE — VSCode terminals inherit it and it forces Node-only mode.
const childEnv = { ...process.env };
delete childEnv.ELECTRON_RUN_AS_NODE;
execSync('electron . --scrape', { stdio: 'inherit', cwd: projectRoot, env: childEnv });
4 changes: 4 additions & 0 deletions scripts/watch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,12 @@ function setupMainPackageWatcher({ resolvedUrls }) {
}

/** Spawn new electron process */
// Strip ELECTRON_RUN_AS_NODE — VSCode terminals inherit it and it forces Node-only mode.
const childEnv = { ...process.env };
delete childEnv.ELECTRON_RUN_AS_NODE;
electronApp = spawn(String(electronPath), ['--inspect', '.'], {
stdio: 'inherit',
env: childEnv,
});

/** Stops the watch script when the application has been quit */
Expand Down
Loading