fix: Make sure params get passed through for compiled prompt

[Abhijeet Prasad (AbhiPrasad)]

resolves https://linear.app/braintrustdata/issue/BT-4378/typescript-sdk-promptbuild-fields-response-format-tool-choice

This fixes a bug with typings where params were not being passed through correctly.

import OpenAI from "openai";
import { Prompt } from "braintrust";

declare const prompt: Prompt;

const params = prompt.build(
  { topic: "TypeScript" },
  { flavor: "chat" },
);

// Before the fix, these would fail
// Property 'temperature' does not exist on type 'CompiledPrompt<"chat">'
const temperature = params.temperature;
const responseFormat = params.response_format;
const toolChoice = params.tool_choice;

I didn't add a test for this because it's just a types change, but lmk and I can add a set of type check tests.

[Abhijeet Prasad (AbhiPrasad)]

Hmm, this is a breaking change, but it's one for correctness. We can just leave this PR until the next major version though.

[Luca Forstner (lforst)]

Why exactly is this a breaking change? It doesn't seem like one cause we simply widen a return type no? The compatibility CI check is sometimes overly sensitive because it's literally comparing the text of TS definitions.

[Abhijeet Prasad (AbhiPrasad)]

Ah okay we are fine. I over though it. We did break params.response_format.json_schema.schema, but that would have been busted before anyway. So this change is safe.