ref: Use diagnostics channels for ai sdk wrapper#1675
Merged
Luca Forstner (lforst) merged 10 commits intomainfrom Mar 31, 2026
Merged
ref: Use diagnostics channels for ai sdk wrapper#1675Luca Forstner (lforst) merged 10 commits intomainfrom
Luca Forstner (lforst) merged 10 commits intomainfrom
Conversation
Abhijeet Prasad (AbhiPrasad)
approved these changes
Mar 31, 2026
| return undefined; | ||
| } | ||
|
|
||
| function extractTokenMetrics(result: any): Record<string, number> { |
There was a problem hiding this comment.
this (and some other test methods) are duplicated from ai-sdk-plugin. I would prefer if we share them as common utils so things don't drift.
Member
Author
There was a problem hiding this comment.
I am gonna do this in a follow-up so that this PR doesn't become too unwieldy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves over the AI SDK wrapper to fully use diagnostics channels.
Additional stuff: