fix(openai): Fix wrapOpenAI breaking native private fields of client#1704
Merged
Luca Forstner (lforst) merged 4 commits intomainfrom Mar 31, 2026
Merged
fix(openai): Fix wrapOpenAI breaking native private fields of client#1704Luca Forstner (lforst) merged 4 commits intomainfrom
wrapOpenAI breaking native private fields of client#1704Luca Forstner (lforst) merged 4 commits intomainfrom
Conversation
Luca Forstner (lforst)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Stephen Belanger (Qard)
Abhijeet Prasad (AbhiPrasad)
approved these changes
Mar 31, 2026
|
|
||
| for (const scenario of openaiScenarios) { | ||
| const assertPrivateFieldMethodsOperation = | ||
| scenario.snapshotName === "openai-v6"; |
There was a problem hiding this comment.
nit: we should probably check scenario.version instead, as v7 of openai will have the same issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to address #1693
Please see comments in code for further explanation.
We didn't chose the original approach the referenced issue takes (
Reflect.get(..., target)) because it doesn't work sincethisis still the proxied instance.