fix(auto-instrumentation): Upgrade @apm-js-collab/code-transformer to v0.11.0#1708
Open
Stephen Belanger (Qard) wants to merge 2 commits intomainfrom
Open
fix(auto-instrumentation): Upgrade @apm-js-collab/code-transformer to v0.11.0#1708Stephen Belanger (Qard) wants to merge 2 commits intomainfrom
Stephen Belanger (Qard) wants to merge 2 commits intomainfrom
Conversation
258f7d9 to
83cddb0
Compare
Luca Forstner (lforst)
approved these changes
Mar 31, 2026
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
83cddb0 to
4d6b622
Compare
…r v0.11.0 JS rewrite - Bump version range to >=0.9.0 to pick up v0.11.0 when released - Fix ESM loader hook to pass correct module type (esm/cjs/unknown) from Node.js loader format instead of always passing "unknown", which caused CJS require() to be injected into ESM files - Remove tracePromise assertions from transformation tests (implementation detail of old WASM output; new JS version uses runStores instead) - Clean up "WASM transformer" wording in comments Tested against nodejs/orchestrion-js main branch. The browser-mode tests (dc-browser) require apm-js-collab/dc-browser#3 to be merged and released first, since dc-browser was missing a default export to match node:diagnostics_channel's CJS-ESM interop behaviour. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
v1.0.4 adds a default export to match Node.js CJS-ESM interop behaviour, which is required for the diagnostics_channel-based wrappers to work correctly in mixed ESM/CJS projects. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4d6b622 to
74be407
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@apm-js-collab/code-transformerfrom^0.9.0to^0.11.0, picking up the v0.11.0 JS rewrite (replaces the previous WASM-based transformer)esm/cjs/unknown) based on Node.js loader format, instead of always passing"unknown"— this was causing CJSrequire()to be injected into ESM (.mjs) filestracePromiseassertions from transformation tests (implementation detail of the old WASM output; the new JS transformer usesrunStoresinstead)dc-browserto v1.0.4, which adds a default export to match Node.js CJS-ESM interop behaviour required by the diagnostics_channel-based wrappersTest plan
pnpm testinjs/)🤖 Generated with Claude Code