braintrust/temporal #1261

clutchski · 2026-01-13T20:28:19Z

This PR adds braintrust tracing to temporal.

A new package @braintrust/temporal has been added that handles tracing temporal workflows.

Qard

Not sure how much we care about the peer dependency, but otherwise LGTM.

Qard · 2026-01-14T17:02:37Z

js/package.json

+    "@temporalio/workflow": "^1.11.0",
    "zod": "^3.25.34 || ^4.0"
+  },
+  "peerDependenciesMeta": {


Yarn does not support peerDependenciesMeta. It will only yell at you about unsatisfied peer dependencies though but will continue installation anyway. Slight DX issue, but still works.

ankrgyl · 2026-01-14T17:27:58Z

Does the peer dependency mean that you will have to install temporal when you install our SDK (although it is not bundled)?

Qard · 2026-01-14T17:31:19Z

Because it has peerDependenciesMeta with optional: true it is not required to install temporal together with the SDK. Yarn, however, does not support this--only npm and pnpm do--but it doesn't actually enforce peer dependencies at all anyway, it just warns you a peer dependency is missing but then completes the install anyway.

The DX sucks a bit as it will look like it is expecting temporal to be installed when it actually doesn't need it. But users can safely ignore that warning.

ibolmo

going to stop my review since I did find a non-starter.

ibolmo · 2026-01-14T17:55:14Z

js/smoke/tests/otel-v1/tsconfig.json

-    "include": ["otel_example.ts"],
-    "exclude": ["node_modules"]
-  }
+  "compilerOptions": {


#nit i wonder why your setup did this

is it prettier that did this?

ibolmo · 2026-01-14T17:56:27Z

js/src/wrappers/temporal/index.ts

+ * import { Client, Connection } from "@temporalio/client";
+ * import { Worker } from "@temporalio/worker";
+ * import * as braintrust from "braintrust";
+ * import { createBraintrustTemporalPlugin } from "braintrust/wrappers/temporal";


#nit example needs an update to use braintrust.

ibolmo · 2026-01-14T18:02:32Z

integrations/temporal-js/src/plugin.ts

@@ -0,0 +1,128 @@
+import type { ClientPlugin, ClientOptions } from "@temporalio/client";


types are stripped off automatically when bundled, so this is ok still.

ibolmo · 2026-01-14T18:04:16Z

integrations/temporal-js/src/interceptors.ts

+  ActivityInterceptors,
+} from "@temporalio/worker";
+import type { WorkflowClientInterceptor } from "@temporalio/client";
+import { defaultPayloadConverter } from "@temporalio/common";


ok this is not a type and will break braintrust installs that do not tree shake and that they don't have the temporalio client installed.

@Qard may confirm my understanding

looks like sanity tests are indeed failing (correctly): https://github.com/braintrustdata/braintrust-sdk/actions/runs/20974131523/job/60285471728?pr=1261#step:8:47

I think your only recourse is to create a separate package 🙉

Ah, right. Yes. Bundling woes. 🙈

This will indeed fail. Though the peer dependency thing is fine (ish), having imports of these anywhere that gets included in the bundle will indeed make it required as a proper dependency.

mjameswh · 2026-01-14T22:31:17Z

Hey there! I'm James, from the Temporal's SDK team.

I'm not familiar with braintrust-sdk, but it looks like your repository contains an integration directory, with optional features as distinct npm packages.

Is there any reason not to define the Temporal integration as a distinct package? This would ensure that your main package isn't linked to the Temporal SDK. Or am I missing something?

- Add temporal wrapper with client, activity, and workflow interceptors - Export createBraintrustClientInterceptor, createBraintrustActivityInterceptor, createBraintrustSinks from braintrust package - Export workflow-interceptors as separate entry point for workflow isolate - Update example to use SDK exports instead of local implementation - Add mise kill task for force stopping server Co-Authored-By: Claude Opus 4.5 <[email protected]>

Activities running on different workers than the workflow now correctly parent to the workflow span instead of the client span. This is done by passing the workflowSpanId in headers and reconstructing the parent SpanComponentsV3 in the activity interceptor. Co-Authored-By: Claude Opus 4.5 <[email protected]>

Tests for: - Header serialization/deserialization utilities - SpanComponentsV3 reconstruction for cross-worker parent propagation Co-Authored-By: Claude Opus 4.5 <[email protected]>

Replace manual interceptor setup with a simpler plugin API: - Add BraintrustTemporalPlugin class implementing ClientPlugin and WorkerPlugin - Add createBraintrustTemporalPlugin() factory function - Update example to use plugin pattern - Make interceptors internal (not exported from public API) - Add plugin tests Usage: ```typescript const plugin = createBraintrustTemporalPlugin(); const client = new Client({ plugins: [plugin] }); const worker = await Worker.create({ plugins: [plugin], ... }); ``` Co-Authored-By: Claude Opus 4.5 <[email protected]>

Demonstrates that tracing context is properly propagated within activities, allowing nested spans to be created using braintrust.traced(). Co-Authored-By: Claude Opus 4.5 <[email protected]>

The test was incorrectly flagging @temporalio/client because "client" contains "cli". Changed the check to only match actual /cli/ directory paths, not package names that happen to contain "cli" as a substring. Co-Authored-By: Claude Opus 4.5 <[email protected]>

…flowModules - Use `new BraintrustTemporalPlugin()` instead of factory function - Plugin now automatically adds workflow interceptors via workflowModules - Users no longer need to manually specify workflowModules in worker config Co-Authored-By: Claude Opus 4.5 <[email protected]>

- Replace global variables with per-workflow state object - Each workflow gets its own isolated state via the factory function - Remove examples from pnpm workspace - they use published npm package Co-Authored-By: Claude Opus 4.5 <[email protected]>

clutchski

why remove mise? it makes things very simple (mise install to get all the tools, etc).

…object_metadata_args

cpinn · 2026-01-16T22:59:23Z

why remove mise? it makes things very simple (mise install to get all the tools, etc).

I didn't really like mise. I have added it back but kept pnpm instead.

I did need to make a few changes to the interceptors file. I was getting some weird trace hierarchies/occasionally multi span. I think the condition was maybe a bit too strict and the new condition also looks for compute_object_metadata_args which apparently the python implementation did as an alternative to object_id. If that looks wrong let me know but I now consistently get the trace hierarchy below.

Qard approved these changes Jan 14, 2026

View reviewed changes

ibolmo reviewed Jan 14, 2026

View reviewed changes

clutchski and others added 10 commits January 15, 2026 12:56

add temporal example

7414db3

Add unit tests for Temporal integration

6e1305a

Tests for: - Header serialization/deserialization utilities - SpanComponentsV3 reconstruction for cross-worker parent propagation Co-Authored-By: Claude Opus 4.5 <[email protected]>

Add child span example in Temporal activity

85bf564

Demonstrates that tracing context is properly propagated within activities, allowing nested spans to be created using braintrust.traced(). Co-Authored-By: Claude Opus 4.5 <[email protected]>

separate entry point

035c055

clutchski force-pushed the matt/temporal.js branch from d562403 to 035c055 Compare January 15, 2026 17:58

clutchski and others added 2 commits January 15, 2026 13:30

Exclude Temporal wrapper from typedoc (imports external braintrust)

87c48a1

Move temporal to a new package @braintrust/temporal

3b15fe9

cpinn force-pushed the matt/temporal.js branch from e87d531 to 3b15fe9 Compare January 15, 2026 21:16

cpinn added 3 commits January 15, 2026 13:28

update example to remove mise

b53502e

update lockfile

877f4c2

add build system for new package

6562983

clutchski commented Jan 16, 2026

View reviewed changes

cpinn added 4 commits January 16, 2026 13:49

small tweaks to instructions

9dc32c6

add fix for span interceptor

6444978

add back mise, properly fix trace hierarchy by adding in the compute_…

1eff127

…object_metadata_args

fix mise install to properly install pnpm deps

c9a96e9

cpinn marked this pull request as ready for review January 19, 2026 05:20

cpinn changed the title ~~Matt/temporal.js~~ braintrust/temporal Jan 19, 2026

cpinn merged commit 2dc8187 into main Jan 19, 2026
71 checks passed

cpinn deleted the matt/temporal.js branch January 19, 2026 16:41

		@@ -0,0 +1,128 @@
		import type { ClientPlugin, ClientOptions } from "@temporalio/client";

braintrust/temporal #1261

braintrust/temporal #1261

Conversation

clutchski commented Jan 13, 2026 • edited by cpinn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Qard left a comment

Choose a reason for hiding this comment

Uh oh!

Qard Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

ankrgyl commented Jan 14, 2026

Uh oh!

Qard commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ibolmo left a comment

Choose a reason for hiding this comment

Uh oh!

ibolmo Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

clutchski Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

ibolmo Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

ibolmo Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

ibolmo Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Qard Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

mjameswh commented Jan 14, 2026

Uh oh!

clutchski left a comment

Choose a reason for hiding this comment

Uh oh!

cpinn commented Jan 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

clutchski commented Jan 13, 2026 •

edited by cpinn

Loading

Qard commented Jan 14, 2026 •

edited

Loading