Repository navigation
fix: parse legacy and modern FFmpeg format columns - #440
Merged
Merged
Conversation
The regex accepts an optional space or `d` after the two capability columns, supporting both legacy and modern output while preserving the existing capability capture. A new fixture and test cover modern formats and devices, malformed rows, and caching of the parsed result. Fixes bramp#408
Owner
|
Very cool. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex accepts an optional space or
dafter the two capability columns, supporting both legacy and modern output while preserving the existing capability capture. A new fixture and test cover modern formats and devices, malformed rows, and caching of the parsed result.FFmpeg.formats() returns an empty list when FFmpeg prints the newer format table, preventing callers from discovering supported formats. The parser expected only the demuxing and muxing columns before the format name. Newer output includes a third column containing a space or a device marker, so those rows failed to match.
FFmpegTest passed all 10 tests with no failures, errors, or skips.
Fixes #408
AI was used for assistance.