fix(BREV-9479): inline lifecycle script body when deploying launchable via CLI#394
Open
harshsharmanv wants to merge 1 commit into
Open
fix(BREV-9479): inline lifecycle script body when deploying launchable via CLI#394harshsharmanv wants to merge 1 commit into
harshsharmanv wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brev create <name> --launchable <id>failed withrpc error: code = Internal desc = lifecycle script is emptywhenever the launchable had a lifecycle script attached.lifeCycleScriptAttras an{id, name}reference; the script body is stored in blobstore and is not inlined, passed on user's request but not returned on get or list. The backend's create-workspace path requires the client to supply the script content.GET /api/launchable/lifecycle-script?envId=...&scriptId=...and inlining the response intoattrs.scriptbefore sending create request. The CLI did not, it forwarded the reference as-is.This PR makes the CLI mirror the Brev Console:
AuthHTTPStore.GetLaunchableLifeCycleScripthitting the same endpoint the Console uses.fetchAndDisplayLaunchablenow callsinlineLaunchableLifeCycleScript, which fetches and inlines the body whenattr.IDis set andattr.Scriptis empty.idpresence, so launchables with no lifecycle script remain unaffected — the field staysnil,omitemptydrops it from the POST, and the backend'shasLifecycleScriptreturns false (no validation).