use a different method to obtain the HTTP status code in the JsonRpcRestClient - #358
Open
cyb3r4nt wants to merge 1 commit into
Open
use a different method to obtain the HTTP status code in the JsonRpcRestClient#358cyb3r4nt wants to merge 1 commit into
cyb3r4nt wants to merge 1 commit into
Conversation
HttpStatusCodeException.getStatusCode() has been moved in spring-web v6 into parent class RestClientResponseException. This causes missing methods errors if code is compiled with spring-web v5, but is running with spring-web v6. Method RestClientResponseException.getRawStatusCode() is present in both spring-web versions, but it is deprecated in spring-web v6. When jsonrpc4j code migrates to spring-web v6 or higher, then this place will need to migrate back to getStatusCode() method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpStatusCodeException.getStatusCode()has been moved in spring-web v6 into parent classRestClientResponseException.This causes missing methods errors if code is compiled with spring-web v5, but is running with spring-web v6.
Method
RestClientResponseException.getRawStatusCode()is present in both spring-web versions, but it is deprecated in spring-web v6. When jsonrpc4j code migrates to spring-web v6 or higher, then this place will need to migrate back to thegetStatusCode()method.