Skip to content

Fix problems detected by PHPStan #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix problems detected by PHPStan #6

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
687886c
Fix
szepeviktor Apr 16, 2023
38f1fc6
Fix
szepeviktor Apr 16, 2023
3287b0f
Fix
szepeviktor Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Reflection/Reflector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ private function getParameterTypeFromDocComment(ReflectionParameter $parameter):

$pattern = '/@param(.*)\$' . $parameter->getName() . '\W/';

/** @var list<array{string}> $matches */
preg_match_all($pattern, $docComment, $matches, PREG_SET_ORDER);
/** @var list<list<string>> $matches */
Comment on lines -151 to +152
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$match comes into existence after preg_match_all


if (count($matches) === 0) {
return null;
Expand Down Expand Up @@ -238,7 +238,7 @@ private function getParameterTypeFromReflection(ReflectionType $type, Reflection
if ($type instanceof ReflectionUnionType) {
return $this->createUnionType(
array_map(
function (ReflectionNamedType|ReflectionIntersectionType $type) use ($reflectionParameter): SimpleType|ClassType|EnumType|ArrayType {
function (ReflectionNamedType|ReflectionIntersectionType $type) use ($reflectionParameter): SimpleType|ClassType|EnumType {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convertNamedType does not return ArrayType

/** @psalm-suppress DocblockTypeContradiction https://github.com/vimeo/psalm/issues/9079 */
if ($type instanceof ReflectionIntersectionType) {
$this->throwOnIntersectionType($reflectionParameter);
Expand Down