prevent unnecessary tile calc and set radius size#229
Open
cornhundred wants to merge 3 commits intomainfrom
Open
prevent unnecessary tile calc and set radius size#229cornhundred wants to merge 3 commits intomainfrom
cornhundred wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances visualization performance and configurability by adding controls for tile calculation and point cloud radius sizing. The changes prevent unnecessary tile calculations for point cloud technology and allow configurable radius settings.
- Added configurable point cloud radius parameter with default value of 5
- Implemented conditional tile calculation logic to skip processing for point-cloud technology
- Added max_tiles_to_view parameter to control tile loading thresholds
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/celldega/viz/widget.py | Added max_tiles_to_view and point_cloud_radius traitlets parameters |
| pyproject.toml | Version bump from 0.14.0a2 to 0.14.0a3 |
| package.json | Version bump from 0.14.0-alpha.2 to 0.14.0-alpha.3 |
| js/widget.js | Added point_cloud_radius parameter extraction and passing |
| js/viz/landscape_ist.js | Added point_cloud_radius parameter and initialization in viz_state |
| js/ui/sliders.js | Updated cell slider calculation to use configurable radius |
| js/deck-gl/layers/cell_layer.js | Updated pointSize to use configurable radius value |
| js/deck-gl/core/calc_viewport.js | Added conditional logic to skip tile calculations for point-cloud technology |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ); | ||
|
|
||
| } else { | ||
| tiles_in_view = [] |
There was a problem hiding this comment.
Missing semicolon at the end of the statement. JavaScript statements should end with semicolons for consistency and to avoid potential issues.
Suggested change
| tiles_in_view = [] | |
| tiles_in_view = []; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.