allow custom placeholder for missing data in tsv_join task#227
Open
allow custom placeholder for missing data in tsv_join task#227
Conversation
allow custom placeholder for missing data in tsv_join task, set default to "?" for tsv join of nextmeta-format input in sarscov2_nextstrain workflow
dpark01
requested changes
Mar 11, 2021
Member
dpark01
left a comment
dpark01
left a comment
There was a problem hiding this comment.
Oh man... I didn't realize this was a thing. One suggested change, otherwise it's probably good.
Wouldn't hurt to test it a little bit--not necessarily as unit tests in viral-pipelines, but just to sanity check the behavior offline. Here are the inputs I was using before.. you could imagine a version of these with ?.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow custom placeholder for missing data in tsv_join task, set default to "?" for tsv join of nextmeta-format input in sarscov2_nextstrain workflow