Fixed Registration Bug: soft deleted user cannot re-register - throws unhandled error#1810
Open
teddy-aisoft wants to merge 1 commit intobrocoders:mainfrom
Open
Fixed Registration Bug: soft deleted user cannot re-register - throws unhandled error#1810teddy-aisoft wants to merge 1 commit intobrocoders:mainfrom
teddy-aisoft wants to merge 1 commit intobrocoders:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a user cannot re-register after deletion. This is because a soft delete leaves the record, and the re-registration tries to create a record with an email that violates the unique key constraint. I add logic to handle in the user service by fully deleting the user, and then re-creating. This also requires modifying the on delete action for the Session entity. I added the ORM config and migration change to handle.