Skip to content

Add plugin typings from DefinitelyTyped#657

Open
matrosov-nikita wants to merge 1 commit intobrody2consult:devfrom
matrosov-nikita:add-types
Open

Add plugin typings from DefinitelyTyped#657
matrosov-nikita wants to merge 1 commit intobrody2consult:devfrom
matrosov-nikita:add-types

Conversation

@matrosov-nikita
Copy link
Copy Markdown

No description provided.

@brody2consult
Copy link
Copy Markdown
Owner

Thanks @matrosov-nikita for the contribution. I still have to consider this one. In general I would prefer to keep this in an external project that would be referenced by the documentation.

An extra bonus would be to find a way to share common types such as ResultSet between Web SQL and this plugin.

A further bonus may be to consider wrapping https://github.com/brodybits/sql-promise-helper ref: brody2consult/sql-promise-helper#2

brody2consult pushed a commit that referenced this pull request Apr 18, 2018
brody2consult pushed a commit that referenced this pull request Apr 18, 2018
brody2consult pushed a commit that referenced this pull request Apr 18, 2018
additional documentation items by @brodybits (Christopher J. Brody)

ref: #657
@brody2consult brody2consult changed the base branch from storage-master to dev February 18, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants