Skip to content

Conversation

nullvoids
Copy link

@nullvoids nullvoids commented Mar 10, 2017

I'm expecting all the rows of the response to return in the success callback. This PR returns the rows as part of the response

@nullvoids nullvoids changed the title change response Change response payload to return rows Mar 10, 2017
@jackyl14
Copy link

Great change, @sollabeck ! I will use this branch in my hybrid app until this gets merged into the next plugin release hopefully.

This allows my code to expect the same websql callback response in my browser that does not use the cordova plugin and in my iOS and Android apps that uses this cordova plugin.

@jackyl14
Copy link

works like a charm!

@brody4hire
Copy link
Owner

Thanks @sollabeck, this would definitely be a nice enhancement. I will probably reimplement your idea in CoffeeScript in a way so that the user can both get array access and continue to use the "standard" item() member function. I just raised #71 to implement this idea and add map access.

@brody4hire brody4hire changed the base branch from cordova-sqlite-ext-master to latest February 14, 2019 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants