Skip to content

test: EWM-639 approval_listener test#1191

Open
knightsforce wants to merge 1 commit intodevfrom
feature/EWM-639-approvals_listener
Open

test: EWM-639 approval_listener test#1191
knightsforce wants to merge 1 commit intodevfrom
feature/EWM-639-approvals_listener

Conversation

@knightsforce
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds unit test coverage for browser approvals-listener network handling (EWM-639), validating both model-level network switching and AddNetworkConnection parsing.

Changes:

  • Add tests for ChangeNetworkModel.changeConnection / AddNetworkModel.changeNetwork waiting on a matching currentTransportStream strategy.
  • Add tests for AddNetworkExtension.getConnection() to ensure correct ConnectionWorkchain construction for GraphQL/proto inputs and failure on invalid type.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/feature/browser/approvals_listener/network_models_test.dart Verifies changeConnection/changeNetwork persist selected connection id and resolve once the matching transport strategy appears on the stream.
test/feature/browser/approvals_listener/add_network_extension_test.dart Verifies AddNetwork.getConnection() builds expected custom connection/workchain for GraphQL and proto inputs and throws on unsupported type.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants