Further Implementation of the EIP-681 spec + Optimizations#11
Open
lucemans wants to merge 30 commits into
Open
Further Implementation of the EIP-681 spec + Optimizations#11lucemans wants to merge 30 commits into
lucemans wants to merge 30 commits into
Conversation
brunobar79
reviewed
May 9, 2022
brunobar79
left a comment
brunobar79
left a comment
Owner
There was a problem hiding this comment.
Thank you so much for doing this! Looks great.
Added a few comments and I'm happy to take another look after the readme is updated and the comments addressed.
Author
|
Sweet! I will get around to them as soon as possible! |
|
Looks cool! |
brunobar79
reviewed
May 23, 2022
brunobar79
left a comment
brunobar79
left a comment
Owner
There was a problem hiding this comment.
Looking good! added a few more comments
Co-authored-by: Bruno Barbieri <brunobar79@gmail.com>
Co-authored-by: Bruno Barbieri <brunobar79@gmail.com>
Co-authored-by: Bruno Barbieri <brunobar79@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For starters, thank you very much for the existence of this package.
As a desire to further support more of the features described in EIP-681 in the modern wallet this PR has been made.
Here are some of the changes that this PR includes
144kb=>4.4kbqsas it does not support multiple parameters with the same nameThings left to do:
Looking forward to hearing from you!