Feature/reporting state - #136
Conversation
joshvote
left a comment
There was a problem hiding this comment.
Is it a fair summary that this loads up the finalize zip with a new "json dump" file and then orchestrator can go do what it wants with it?
It wasn't how I initially imagined it (I was initially imagining a new endpoint to collect data on demand) but that's not a judgement call. It might actually be a lighter weight way of managing things...
|
Yes that is a fair summary. The problem is not so much around having a dedicated end-point but about when the reporting data is collected...
Which is why I landed on returning the reporting data during finalise. However finalise already must return a zip of other files that cannot be generated by the orchestrator. The workaround was to return the reporting data inside the zip. JSON seemed the logical choice because it could easily be converted back into the python objects that the report generation code needs. A small bonus is we can return the PDF (generated by the runner) and the reporting data and then later compare the original (runner) PDF with the orchestrator-generated PDF to see that they match. |
80ceae7 to
51c1438
Compare
604c7ef to
bdc1caf
Compare
…ature/reporting-state
…ctus-runner into feature/reporting-state
ReportingDatadataclass and writes the data to a .json file in the zip archive, that is returned to the orchestrator during finalization.