This repository was archived by the owner on Nov 8, 2021. It is now read-only.
Fix namespace and make IPN callback work as it creates a new invoice …#48
Open
ndeet wants to merge 1 commit into
Open
Fix namespace and make IPN callback work as it creates a new invoice …#48ndeet wants to merge 1 commit into
ndeet wants to merge 1 commit into
Conversation
…and fails with old Currency class.
|
+1 Having same warning from composer: Class Bitpay\CurrencyUnrestricted located in ./vendor/btcpayserver/btcpayserver-php-client/src/BTCPayServer/CurrencyUnrestricted.php does not comply with psr-4 autoloading standard. Skipping. Why is this PR not accepted yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and fails with old Currency class.
Namespace was wrong as I was not aware that this repo is a clone with imports and some minor mods from the other bitpay php client repo.
Also fixed invoice creation that is triggeren on the IPN callback processing. We need to use the CurrencyUnrestricted class there to avoid making the Client fail because of currency symbol restrictions.