N+1 problem fixed on member filter saving 10 queries a page

[phe-sto]

• Existing functions are isofunctional.
• bp_activity_get_user_mentionname splited in two as only requires ID and login which are provides in many cases. If present formatting can be called without querying user data in base again.
• bp_activity_get_user_mentionname replaced by bp_activity_format_mentionname in bp-members-filters.php saving my site 10 queries on feed page.

I have not check yet if bp_activity_get_user_mentionname could be replace by bp_activity_format_mentionname in other scripts.

[welcome]

Thanks for your pull request. It looks like this may be your first contribution to the BuddyBoss Platform open source project. Please note that this project and all contributions to it are public and bounded by the GPL v2.0 license, and that a record of the contribution (including all personal information you submit with it, including your full name and email address) is maintained indefinitely and may be redistributed with this project. If you are not okay with these terms, please close this pull request. Alternatively, you can let us know about your concerns by adding a comment to this pull request.

[phe-sto]

Hi @chetansatasiya,
Sorry I haven't so your remarks earlier. I have of course committed your suggested changes.
Thank you for the review.
Best-regards

[chetansatasiya]

@phe-sto Make the code format properly, as it breaking exisitng code format use the WordPress PHPCBF

[phe-sto]

@chetansatasiya I don't get it, what and where is it broken?

[chetansatasiya]

I would recommend to run the PHPCS and PHPCBF and it will correct.

[phe-sto]

@chetansatasiya ok I reformated my code using this:

$ phpcbf --standard=WordPress src/bp-xprofile/bp-xprofile-functions.php

PHPCBF RESULT SUMMARY
---------------------------------------------------------------------------------------------------------------------------
FILE                                                                                                       FIXED  REMAINING
---------------------------------------------------------------------------------------------------------------------------
/home/chrichri/blockchain-over-rf/haven-0/buddyboss-platform/src/bp-xprofile/bp-xprofile-functions.php     3264   114
---------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 3264 ERRORS WERE FIXED IN 1 FILE
---------------------------------------------------------------------------------------------------------------------------

Time: 1.31 secs; Memory: 48MB

But only kept the lines I changed.