Remove incorrect album_id filter from video theatre query#4904
Open
GaryJones wants to merge 1 commit intobuddyboss:releasefrom
Open
Remove incorrect album_id filter from video theatre query#4904GaryJones wants to merge 1 commit intobuddyboss:releasefrom
GaryJones wants to merge 1 commit intobuddyboss:releasefrom
Conversation
The video theatre AJAX handler passes album_id => 'existing-video' when querying for a specific video by ID. This value is interpreted as album_id = 0 by the query, restricting results to videos that do not belong to any album. Videos attached to an album are excluded, breaking theatre playback for album-associated videos. Since the query already filters by a specific video ID via the 'include' parameter, the album_id restriction is unnecessary and counterproductive. Remove it so all videos are found regardless of album association.
chetansatasiya
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The video theatre AJAX handler in
bp-templates/bp-nouveau/includes/video/ajax.phppasses'album_id' => 'existing-video'when querying for a specific video by its ID. The query layer interprets this non-numeric value asalbum_id = 0, which restricts results to videos that do not belong to any album.This means that when a user clicks to view a video in theatre mode that is associated with an album, the query returns no results and playback fails silently.
Fix
Remove the
album_idparameter from the query arguments. The query already filters by a specific video ID via the'include'parameter, so the album_id restriction is redundant. Without it, videos are found regardless of whether they belong to an album or not.Test plan