Skip to content

v1.0.24#66

Merged
yilmaztayfun merged 2 commits into
release-v1.0from
master
May 18, 2026
Merged

v1.0.24#66
yilmaztayfun merged 2 commits into
release-v1.0from
master

Conversation

@yilmaztayfun

@yilmaztayfun yilmaztayfun commented May 18, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Update SonarCloud analysis workflow to use .NET 10.0.x with explicit restore and no-restore build, and align the repository SDK version with the newer patch release.

Build:

  • Configure the SonarCloud GitHub Actions workflow to install .NET 10.0.x, restore the solution before analysis, and build without restoring during the Sonar scan step.

CI:

  • Align the CI SonarCloud workflow with the updated .NET SDK and build/restore sequence for more reliable analysis.

yilmaztayfun and others added 2 commits May 18, 2026 11:40
…try-tracing-spans-to-distributed-event-bus-pipeline

global sdk update
@yilmaztayfun yilmaztayfun self-assigned this May 18, 2026
@yilmaztayfun yilmaztayfun requested review from a team May 18, 2026 08:41
@sourcery-ai

sourcery-ai Bot commented May 18, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the SonarCloud GitHub Actions workflow to use a specific .NET 10 SDK version with explicit restore before build, and bumps the repository’s pinned .NET SDK patch version in global.json.

File-Level Changes

Change Details Files
Configure the SonarCloud CI workflow to set up .NET SDK 10, restore dependencies explicitly, and build without restoring to align with the updated SDK configuration.
  • Add a setup step in the SonarCloud workflow to install .NET SDK version 10.0.x via actions/setup-dotnet@v4.
  • Introduce a separate step to run dotnet restore on the solution before analysis and build.
  • Adjust the build step to use dotnet build with the --no-restore flag to rely on the earlier restore step.
.github/workflows/check-sonar.yml
Update the repository-wide pinned .NET SDK version to a newer 10.0.103 patch release.
  • Change the sdk.version in global.json from 10.0.101 to 10.0.103 while keeping rollForward behavior unchanged.
global.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a8e21a62-54ec-48aa-a2ad-fa917bedac76

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch master

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yilmaztayfun yilmaztayfun merged commit 2f38864 into release-v1.0 May 18, 2026
5 of 6 checks passed
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In the workflow, consider pinning actions/setup-dotnet to the exact SDK version from global.json (e.g. 10.0.103 instead of 10.0.x) to avoid unexpected changes when new patch versions are released.
  • Since you've added an explicit dotnet restore, you might want to add a NuGet package cache step (e.g. using actions/cache for the global packages folder) to keep the CI build time reasonable.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the workflow, consider pinning `actions/setup-dotnet` to the exact SDK version from `global.json` (e.g. `10.0.103` instead of `10.0.x`) to avoid unexpected changes when new patch versions are released.
- Since you've added an explicit `dotnet restore`, you might want to add a NuGet package cache step (e.g. using `actions/cache` for the global packages folder) to keep the CI build time reasonable.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sonarqubecloud

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the SDK version in global.json from 10.0.101 to 10.0.103. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant