v1.0.4#23
Conversation
…e-when-same-named-csx-exists-in-multiple-component-directories 10 csx update picks wrong file when same named csx exists in multiple component directories
Reviewer's GuideRefactors the build-and-publish workflow to separate NPM and GitHub publishing, add a pre-publish NPM version check with optional force override, and simplify how publish success is tracked across registries. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new configuration file for the Claude environment, enabling specific web fetching capabilities. This change is foundational for any future features or integrations that require accessing documentation from docs.npmjs.com. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the
Set publish resultstep, a GitHub-only run where the version already exists will exit 0 ingithub-publishwithout settingoutputs.published, soGH_OKis empty andNPM_OKisskipped, causing the workflow to reportpublished=falseeven though the no-op was intentional; consider explicitly settingpublished=false(orskipped) in that branch and adjusting the final logic to treat that case as a non-failure. - The
Publish to NPM (OIDC Trusted Publishing)step switches from a directnpm publishusing an OIDC token toJS-DevTools/npm-publish@v3but notoken/NODE_AUTH_TOKENis provided; if you still intend to rely on OIDC Trusted Publishing, you may need to either reintroduce the explicit OIDC token and pass it into the action or revert to thenpm publishCLI flow that works with npm’s OIDC integration.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the `Set publish result` step, a GitHub-only run where the version already exists will exit 0 in `github-publish` without setting `outputs.published`, so `GH_OK` is empty and `NPM_OK` is `skipped`, causing the workflow to report `published=false` even though the no-op was intentional; consider explicitly setting `published=false` (or `skipped`) in that branch and adjusting the final logic to treat that case as a non-failure.
- The `Publish to NPM (OIDC Trusted Publishing)` step switches from a direct `npm publish` using an OIDC token to `JS-DevTools/npm-publish@v3` but no `token`/`NODE_AUTH_TOKEN` is provided; if you still intend to rely on OIDC Trusted Publishing, you may need to either reintroduce the explicit OIDC token and pass it into the action or revert to the `npm publish` CLI flow that works with npm’s OIDC integration.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a configuration file .claude/settings.json, likely for the Claude AI assistant. My review includes a suggestion to add a comment to this file for clarity. However, there is a significant discrepancy between the code change and the pull request's title ('v1.0.4') and description, which details changes to a CI/CD workflow. Please update the PR's metadata to accurately reflect the contained changes to avoid confusion.
| { | ||
| "permissions": { | ||
| "allow": [ | ||
| "WebFetch(domain:docs.npmjs.com)" | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
For maintainability and to provide context for anyone reviewing this file in the future, it's good practice to document why this permission is being granted. Since JSON files don't support native comments, a common pattern is to add a _comment field explaining the purpose of the configuration. This is especially important for security-related settings like WebFetch.
| { | |
| "permissions": { | |
| "allow": [ | |
| "WebFetch(domain:docs.npmjs.com)" | |
| ] | |
| } | |
| } | |
| { | |
| "permissions": { | |
| "allow": [ | |
| "WebFetch(domain:docs.npmjs.com)" | |
| ] | |
| }, | |
| "_comment": "This permission allows the Claude AI assistant to access documentation from docs.npmjs.com to provide more accurate and context-aware suggestions." | |
| } |
1 participant
Summary by Sourcery
Simplify and harden the release publishing workflow by introducing explicit per-registry version checks and separating NPM and GitHub Packages publish steps, while centralizing the final publish result reporting.
CI: