wizer: Don't copy all memory out of a store #11891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of copying all memory out of a store only copy the contents of the data segments that are created. This refactors the snapshotting process to work with data segments purely with ranges first and then copy out the data at the end once all the ranges have settled. This additionally, while refactoring, adds 64-bit memory support to snapshotting by ensuring that data segments have the right type of offset annotated.
alexcrichton
requested review from
dicej and
fitzgen
and removed request for
a team and
dicej
github-actions
bot
added
the
wizer
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "wizer"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of copying all memory out of a store only copy the contents of the data segments that are created. This refactors the snapshotting process to work with data segments purely with ranges first and then copy out the data at the end once all the ranges have settled. This additionally, while refactoring, adds 64-bit memory support to snapshotting by ensuring that data segments have the right type of offset annotated.